Hacker News story: Ask HN: Is all code patchy and bad in FANG?

Ask HN: Is all code patchy and bad in FANG?
Hi all, this might be naive or silly but I would greatly appreciate your experiences Android dev of 9 years, past: agencies, freelance, research companies, joined FANG 6 months ago. My product is filled with odd side effects, buggy and slow. In my opinion the code is overly complex, classes >2000 lines, doing so many thing with the 20+ class scoped booleans to check for edge cases. Weird architecture that one person holds. Easy to break this, bad customise implementation that tries to take care of every possibility. People make small changes to get impact and push code, I think this loses the bigger pictures and turns ugly quickly. I'm (think) the only one that complains and is worried about this. Is it me or do other people experience the same at FANG? I talked to the authors for a dialog, I think I stepped on toes. Communication was bad, but now has grinded to a halt, with no responses, diffs taking ages to review, no replies, just cc's. It all feels like patch work, these are all smart people. Some coworkers just say "just go with it and do the same". Is this the attitude of FANG? I'm legitimately thinking im a bad fit and leave. How do I validate that I'm not the problem? Maybe it's not overly complicated and I'm too stupid to realize it. Anyone have any tips on how to talk to coworkers without stepping on toes regarding this code? Sorry for chaotic questions. I just feel bad complaining, not being able to offer a solution and coworkers ignoring me. Thanks a lot. Edit: also talked to my managers, it's being discussed higher up apparently. 2 comments on Hacker News.
Hi all, this might be naive or silly but I would greatly appreciate your experiences Android dev of 9 years, past: agencies, freelance, research companies, joined FANG 6 months ago. My product is filled with odd side effects, buggy and slow. In my opinion the code is overly complex, classes >2000 lines, doing so many thing with the 20+ class scoped booleans to check for edge cases. Weird architecture that one person holds. Easy to break this, bad customise implementation that tries to take care of every possibility. People make small changes to get impact and push code, I think this loses the bigger pictures and turns ugly quickly. I'm (think) the only one that complains and is worried about this. Is it me or do other people experience the same at FANG? I talked to the authors for a dialog, I think I stepped on toes. Communication was bad, but now has grinded to a halt, with no responses, diffs taking ages to review, no replies, just cc's. It all feels like patch work, these are all smart people. Some coworkers just say "just go with it and do the same". Is this the attitude of FANG? I'm legitimately thinking im a bad fit and leave. How do I validate that I'm not the problem? Maybe it's not overly complicated and I'm too stupid to realize it. Anyone have any tips on how to talk to coworkers without stepping on toes regarding this code? Sorry for chaotic questions. I just feel bad complaining, not being able to offer a solution and coworkers ignoring me. Thanks a lot. Edit: also talked to my managers, it's being discussed higher up apparently.

Hacker News story: Ask HN: Is all code patchy and bad in FANG? Hacker News story: Ask HN: Is all code patchy and bad in FANG? Reviewed by Tha Kur on October 09, 2021 Rating: 5

No comments:

Powered by Blogger.